Inplace exponential #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 92.86% 92.88% +0.01%
==========================================
Files 5 5
Lines 603 604 +1
==========================================
+ Hits 560 561 +1
Misses 43 43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ccoffrin
reviewed
May 12, 2022
Remove LinearAlgebra from Project.toml, restore Test location in Project.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ccoffrin I changed the exponential to use LinearAlgebra.exp!(A) which reduces memory usage a little bit while using the exact same functionality. It should be noted that I don't think that exp! is actually truly inplace as it doesn't modify the input matrix, it just saves us a copying step that happens under the hood.
I also fixed a bug that I had found in the simulate_de code. Whenever a user passed a kwarg for solve, it would crash. While I was there I also changed it to only save the last value since we only return the final value in its current implementation anyways