V0.10 dev #153
Merged
V0.10 dev #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing an existing pump with an expansion pump provides the same result
Final part of the ne pump code. Adding a constraint relating the build and the status variables of the pumps. Adding the construction cost of ne pumps to the objective function.
|
Merging commits related to expansion pumps so that Byron includes these commits while rebasing the v0.10 branch with the v0.9.3 branch. |
tasseff
reviewed
Feb 19, 2023
| for a in ids(wm, n, :pump) | ||
| # Add pump energy costs to the objective. | ||
| JuMP.add_to_expression!(objective, var(wm, n, :c_pump, a)) | ||
| JuMP.add_to_expression!(objective, var(wm, n, :P_pump, a)) |
There was a problem hiding this comment.
I don't think we should change the objective to minimize power instead of cost, here. The standard OWF minimizes cost. If you want another objective that minimizes power, maybe add this as objective_power or something similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the expansion of pumps