HexRef class #18
Open
HexRef class #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting out, all the source for from HexN::setup_HexN and ref_element::init is now in the constructor for HexRef. The basis and basis derivative evaluation routines from HexN have also been ported over.
No compile yet
- Interface is more or less set - Data structures holding quadrature points in "cells" and on "patches" - Still need to finish data structures holding evaluations of basis functions and their gradients in "cells" and on "patches"
- Created TensorProductBasis class as an interface for evaluations of tensor products of different types of basis function over the hexahedral element - Copied LagrangeElement and LegendreElement classes over from elements/ directory and made them TensorProductBasis derived classes - Copied over quadrature point and weight routines over from elements/ directory and reorganized them
Focus MATAR-Kokkoification in elements-kokkos/
…kkos Merged Steven's Bernstein polynomial and element work in
- Added missing functionality for computing and storing basis function evaluations to HexRef - Fixed a few minor bugs in Bernstein implementation - Added example demonstrating initialization of HexRef and printing out data stored in HexRef In this first implementation, HexRef uses run-time polymorphism to switch between Lagrange, Legendre, and Bernstein tensor product basis evaluations. Dr. Collins suggested that the desired functionality might be better implemented by templating over the basis function type and using compile-time polymorphism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HexRefis a MATAR-Kokkoified fusion of theref_elementandHexNclasses fromelementslibrary.It incorporates Steven Walton's implementation of Bernstein basis functions along with my implementation of Lagrange and Legendre (Jacobi) basis functions.