Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

173 vulture stem mapping to consolidation #174

Merged
merged 9 commits into from
May 7, 2024
Merged

173 vulture stem mapping to consolidation #174

merged 9 commits into from
May 7, 2024

Conversation

ryancb4
Copy link
Collaborator

@ryancb4 ryancb4 commented May 7, 2024

StemProcessor from stems

@ryancb4 ryancb4 self-assigned this May 7, 2024
@ryancb4 ryancb4 added the enhancement New feature or request label May 7, 2024
@ryancb4
Update stem_processor.py
c834f00 
default suffix list
SoloNick
SoloNick requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@SoloNick SoloNick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes required

TELF/pre_processing/Vulture/tokens_analysis/stem_processor.py Outdated Show resolved Hide resolved
TELF/pre_processing/Vulture/tokens_analysis/stem_processor.py Outdated Show resolved Hide resolved
TELF/pre_processing/Vulture/tokens_analysis/stem_processor.py Show resolved Hide resolved
TELF/pre_processing/Vulture/tokens_analysis/stem_processor.py Outdated Show resolved Hide resolved
ryancb4 and others added 2 commits May 7, 2024 15:43
@ryancb4
Update stem_processor.py
d3e757e 
PR change requests completed
@SoloNick
Update stem_processor.py
77ef551 
moved SUFFIXES to be a class constant
SoloNick
SoloNick approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@SoloNick SoloNick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryancb4
Update stem_processor.py
9ee63cf 
name of main function changed to __call__
@ryancb4 ryancb4 merged commit b93ca76 into develop May 7, 2024
2 checks passed
@ryancb4 ryancb4 deleted the 173-vulture-stem-mapping-to-consolidation branch May 7, 2024 22:20
@ryancb4 ryancb4 mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoloNick SoloNick SoloNick approved these changes

@MaksimEkin MaksimEkin Awaiting requested review from MaksimEkin

Assignees

@ryancb4 ryancb4

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryancb4 @SoloNick @MaksimEkin