Add fuzzy histogram, pair-finder memory, and KD Tree pair-finder nodes; fix bugs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modularized pair-finder memory component * Typos corrected
lubbersnick
reviewed
Dec 11, 2023
| @@ -28,7 +28,7 @@ class AutoKw: | |||
| _auto_module_class = NotImplemented | |||
|
|
|||
| def auto_module(self): | |||
| kw = self.module_kwargs or {} # Default to empty dictionary if Falsey | |||
There was a problem hiding this comment.
I know this is way zoomed in on the details, but this is not a typo. "x is truthy" means bool(x) is True, "x is falsey" means "bool(x) is False"
There was a problem hiding this comment.
Ah, I did not know this.
|
Can you update the change log and the documentation to mention the new features? Then I will merge. |
|
@lubbersnick Change log and docs updated. Let me know what you think. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.