Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit on GitHub link broken in online docs #83

Closed
bwohlberg opened this issue Nov 11, 2021 · 2 comments · Fixed by #417 or #422
Closed

Edit on GitHub link broken in online docs #83

bwohlberg opened this issue Nov 11, 2021 · 2 comments · Fixed by #417 or #422
Assignees
@bwohlberg
Labels
documentation Improvements or additions to documentation examples Pertaining to SCICO examples

Comments

@bwohlberg
Copy link
Collaborator

The * Edit on GitHub* links in the online docs (e.g. ct_astra_pcg) are broken because they refer to lanl/scico rather than lanl/scico-data.
@bwohlberg bwohlberg added documentation Improvements or additions to documentation examples Pertaining to SCICO examples labels Nov 11, 2021
@bwohlberg
Copy link
Collaborator Author

This discussion of this issue might help: sphinx-doc/sphinx#2386.

@bwohlberg bwohlberg self-assigned this May 12, 2023
@bwohlberg bwohlberg mentioned this issue May 12, 2023
Merged
bwohlberg added a commit that referenced this issue May 15, 2023
@bwohlberg
Resolve #83 (#417)
5bd958e 
* Attempt to remove rtd edit on github button

* Bump jaxlib/jax max versions

* Remove function no longer in jax.numpy
@bwohlberg
Copy link
Collaborator Author

Broken again in switch to new sphinx theme.

@bwohlberg bwohlberg reopened this May 16, 2023
@bwohlberg bwohlberg linked a pull request May 19, 2023 that will close this issue
Remove Edit on Github button (again) #422
Merged
Michael-T-McCann pushed a commit that referenced this issue May 19, 2023
@bwohlberg @tbalke
Implement #419 review recommendations (#421)
6ac40d4 
* Resolve #261 (#416)

* Improve markup for numpy.float32 etc. as well as some other docs improvements

* Add note to style docs

* Minor docs edit

* Some markup changes

* Resolve #165 (#415)

* Add function for computing gaussian distribution

* Typing fix and better default sigma

* Address #165

* Fix docs typos and suppress apparently-spurious type error

* Target clean also cleans _autosummary directory

* Use new TypeAlias declaration

* Suppress type error

* Avoid pollution of docs with excessively long type alias definition

* Add comment as per PR review suggestion

* Resolve #83 (#417)

* Attempt to remove rtd edit on github button

* Bump jaxlib/jax max versions

* Remove function no longer in jax.numpy

* Resolve #377 (#418)

* Fix markup

* Docstring edits

* Change sphinx theme

* Docstring fixes

* Theme customization

* Clean up

* Fix inheritance diagram insertion

* Resolve document not in any toctree warning for index.ipynb

* Clean up

* Update submodule

* Adjust css

* Avoid problems with dark mode

* Add version number in sidebar

* Change inheritance diagram color scheme

* Clean up

* Correct path to docs_requirements

---------

Co-authored-by: Thilo Balke <thilo.balke@gmail.com>

* Implement PR review recommendations

---------

Co-authored-by: Thilo Balke <thilo.balke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwohlberg bwohlberg

Labels
documentation Improvements or additions to documentation examples Pertaining to SCICO examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #83 lanl/scico
Remove Edit on Github button (again) lanl/scico
1 participant
@bwohlberg