Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loss is_smooth attribute #89

Closed
tbalke opened this issue Nov 12, 2021 · 1 comment · Fixed by #184
Closed

Loss is_smooth attribute #89

tbalke opened this issue Nov 12, 2021 · 1 comment · Fixed by #184
Assignees
@bwohlberg @tbalke @Michael-T-McCann
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Milestone
Release 0.0.2

Comments

@tbalke
Copy link
Contributor

tbalke commented Nov 12, 2021 •
edited
Loading

Currently PGM requires the losses to be smooth (f.is_smooth = True) in order to run although at the same time some of our losses are not smooth, for example, PoissonLoss.

It is still often possible to run PGM (see Poisson examples and TV example) even though the losses are not smooth everywhere by forcing the is_smooth flag to be true.

I suggest re-thinking the use of is_smooth in conjunction with PGM.

Originally posted by @tbalke in #78 (comment)
@tbalke tbalke mentioned this issue Nov 12, 2021
Merged
@bwohlberg bwohlberg added the discussion required Some discussion necessary to decide how to address this issue label Dec 21, 2021
@bwohlberg bwohlberg added this to the Release 0.0.2 milestone Dec 21, 2021
@tbalke
Copy link
Contributor Author

tbalke commented Jan 14, 2022

Agreement during recent meeting, to just remove the attribute.

@bwohlberg bwohlberg removed the discussion required Some discussion necessary to decide how to address this issue label Jan 18, 2022
tbalke added a commit that referenced this issue Jan 19, 2022
@tbalke
remove is_smooth attribute (#89)
f11ba55
@bwohlberg bwohlberg linked a pull request Jan 20, 2022 that will close this issue
remove is_smooth attribute (#89) #184
Merged
1 task
@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Jan 25, 2022
@bwohlberg bwohlberg mentioned this issue Jan 27, 2022
Merged
tbalke added a commit that referenced this issue Jan 27, 2022
@tbalke
remove is_smooth attribute (#89) (#184)
d3b433f 
remove is_smooth attribute (#89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwohlberg bwohlberg

@tbalke tbalke

@Michael-T-McCann Michael-T-McCann

Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Milestone
Release 0.0.2
Development

Successfully merging a pull request may close this issue.

remove is_smooth attribute (#89) lanl/scico
3 participants
@bwohlberg @tbalke @Michael-T-McCann