Address TODO comments in code

[bwohlberg]

There are a number of TODO comments still to be addressed in the code:

• scico/blockarray.py:1322
• scico/__init__.py:8
• scico/numpy/__init__.py:81
• scico/loss.py:73
• scico/typing.py:29
• scico/scipy/special.py:50

[bwohlberg]

Marking scico/__init__.py as done since that instance is now addressed in #138.

[bwohlberg]

Added this issue to the 0.0.2 release milestone. If it's not possible to completely resolve all of these comments in time for this milestone, at the very least the comments should be moved from the code into individual issues describing the required changes.

[bwohlberg]

Re-opening this issue due to the discovery of yet another TODO lurking in the code:

scico/scico/solver.py

Line 192 in ec3dea3

# TODO: need tests for multi-gpu machines

Someone should give it a look to determine whether it can simply be deleted, or whether a corresponding issue should also be created as a reminder to fulfill the intent of the TODO note.

[lukepfister]

here's a better TODO for that part: consider swapping out the calling mechanism with the host callback we use elsewhere in code, then the multi-gpu stuff comes for free

[Michael-T-McCann]

I spun Luke's suggestion out into #204. We could also add an issue about making tests for multi-GPU systems (generically) but I think that's premature.

[lukepfister]

Also, to give some more context-- that TODO is concerning device placement. So if you have some array x on device 0, and you run the solver, does the result go back to device 0? Per this line

scico/scico/solver.py

Line 200 in ec3dea3

if dev:

it should, but there are no actual tests to check that

I'd also be concerned that this code might not work as expected if the array is sharded across multiple devices, but we don't really deal with that in the library

[bwohlberg]

Closing again because subject of TODO note is now discussed in #204, and the line itself will be removed as part of #202.