Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address TODO in code #150

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Address TODO in code #150

merged 3 commits into from
Jan 11, 2022

Conversation

Michael-T-McCann
Copy link
Contributor

closes #96

@codecov
Copy link

codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #150 (6cd3741) into main (3322991) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files          48       48           
  Lines        3294     3295    +1     
=======================================
+ Hits         3035     3036    +1     
  Misses        259      259
Flag Coverage Δ
unittests 92.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/blockarray.py 90.83% <ø> (ø)
scico/scipy/special.py 100.00% <ø> (ø)
scico/loss.py 88.67% <100.00%> (ø)
scico/numpy/__init__.py 100.00% <100.00%> (ø)
scico/typing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3322991...6cd3741. Read the comment docs.

@bwohlberg bwohlberg added the enhancement New feature or request label Dec 24, 2021
@Michael-T-McCann Michael-T-McCann marked this pull request as ready for review January 10, 2022 20:52
bwohlberg
bwohlberg reviewed Jan 10, 2022
View reviewed changes
scico/blockarray.py Outdated Show resolved Hide resolved
bwohlberg
bwohlberg approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo minor suggestions/questions.

@Michael-T-McCann Michael-T-McCann mentioned this pull request Jan 11, 2022
Closed
@Michael-T-McCann Michael-T-McCann merged commit c6cf603 into main Jan 11, 2022
@Michael-T-McCann Michael-T-McCann deleted the mike/todo_96 branch January 11, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwohlberg bwohlberg bwohlberg approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address TODO comments in code
2 participants
@Michael-T-McCann @bwohlberg