Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up scico.solver module #125

Merged
merged 46 commits into from
Dec 7, 2021
Merged

Clean up scico.solver module #125

merged 46 commits into from
Dec 7, 2021

Conversation

bwohlberg
Copy link
Collaborator

  • Remove explicit copies of docstrings from scipy.optimize
  • Remove ToDo notes from docstring and code

Resolves #109.

@bwohlberg bwohlberg added the documentation Improvements or additions to documentation label Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #125 (dad8e0a) into main (f5a18cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          42       42           
  Lines        2997     2997           
=======================================
  Hits         2724     2724           
  Misses        273      273           
Flag Coverage Δ
unittests 90.89% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/solver.py 98.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a18cb...dad8e0a. Read the comment docs.

@bwohlberg bwohlberg merged commit 50e4935 into main Dec 7, 2021
@bwohlberg bwohlberg deleted the brendt/solver branch December 7, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API docs for scico.solver
2 participants