Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explanation of weight in weighted CT example #158

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Fix explanation of weight in weighted CT example #158

merged 3 commits into from
Jan 6, 2022

Conversation

Michael-T-McCann
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann commented Jan 5, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #158 (cb53a86) into main (f5fe2e7) will not change coverage.
The diff coverage is n/a.

❗ Current head cb53a86 differs from pull request most recent head e01eb85. Consider uploading reports for the commit e01eb85 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files          48       48           
  Lines        3294     3294           
=======================================
  Hits         3035     3035           
  Misses        259      259
Flag Coverage Δ
unittests 92.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fe2e7...e01eb85. Read the comment docs.

@Michael-T-McCann Michael-T-McCann marked this pull request as draft January 5, 2022 18:21
@Michael-T-McCann Michael-T-McCann force-pushed the mike/weighted_eq branch 2 times, most recently from 9b4a780 to bfa3d65 Compare January 5, 2022 18:23
@Michael-T-McCann Michael-T-McCann mentioned this pull request Jan 5, 2022
Merged
@Michael-T-McCann Michael-T-McCann force-pushed the mike/weighted_eq branch 2 times, most recently from 7747eb0 to b05652b Compare January 5, 2022 19:44
@bwohlberg
Copy link
Collaborator

Why changes to so many of the notebook files?

@Michael-T-McCann Michael-T-McCann marked this pull request as ready for review January 5, 2022 20:21
@bwohlberg bwohlberg added documentation Improvements or additions to documentation examples Pertaining to SCICO examples labels Jan 6, 2022
@Michael-T-McCann
Copy link
Contributor Author

Why changes to so many of the notebook files?

Good catch, I don't recall it looking like that when I pushed, but so it is now. Fixed.

@Michael-T-McCann Michael-T-McCann enabled auto-merge (squash) January 6, 2022 23:08
@Michael-T-McCann Michael-T-McCann merged commit 19deb2a into main Jan 6, 2022
@Michael-T-McCann Michael-T-McCann deleted the mike/weighted_eq branch January 28, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwohlberg bwohlberg bwohlberg left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Pertaining to SCICO examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equation in docstring does not match corresponding code
2 participants
@Michael-T-McCann @bwohlberg