Check for blockarray inputs in from_operator #229
Conversation
bwohlberg
added
the
improvement
scico/linop/_circconv.py
Outdated
| if is_nested(H.input_shape): | ||
| raise ValueError( | ||
| f"`H.input_shape` ({H.input_shape}) suggests that it " | ||
| "works on `BlockArray`s, but this function assumes " |
There was a problem hiding this comment.
Perhaps rephrase to something like: "... suggests that H takes BlockArray input, which is not supported by this function"? Also, note removal of markup, which is not really of any use in an error message.
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 92.49% 92.50%
=======================================
Files 49 49
Lines 3451 3455 +4
=======================================
+ Hits 3192 3196 +4
Misses 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Check for blockarray inputs in
from_operator.