Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #400 #401

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Address #400 #401

merged 6 commits into from
Apr 19, 2023

Conversation

bwohlberg
Copy link
Collaborator

Address #400.

@bwohlberg bwohlberg linked an issue Apr 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #401 (493bf55) into main (b738a2d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   94.37%   94.40%   +0.02%     
==========================================
  Files          83       83              
  Lines        5053     5056       +3     
==========================================
+ Hits         4769     4773       +4     
+ Misses        284      283       -1     
Flag Coverage Δ
unittests 94.40% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/numpy/util.py 97.36% <ø> (+0.03%) ⬆️
scico/numpy/_wrapped_function_lists.py 100.00% <100.00%> (ø)
scico/numpy/_wrappers.py 98.68% <100.00%> (+1.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwohlberg bwohlberg added the packaging Issues related to packaging, dependencies, etc. label Apr 15, 2023
# with the package.


"""Lists of functions to be wrapped in scico.numpy."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional explanatory text might help:
"These are intended to be the functions in jax.numpy (https://jax.readthedocs.io/en/latest/jax.numpy.html) that should either (1) map over the blocks of a block array (for math functions); (2) map over a tuple of tuples to create a block array (for creation functions); or (3) reduce a block array to a scalar (for reductions).

The links to the numpy docs in the comments are useful for telling these three cases apart, but include extra functions that are not in jax.numpy and should not be listed here.
"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs updated.

@bwohlberg bwohlberg merged commit 670b0e8 into main Apr 19, 2023
17 checks passed
@bwohlberg bwohlberg deleted the brendt/issue#400 branch April 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Issues related to packaging, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numerous warnings with jaxlib/jax >= 0.4.3
2 participants