Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve numerous deprecation warnings #485

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Resolve numerous deprecation warnings #485

merged 12 commits into from
Dec 14, 2023

Conversation

bwohlberg
Copy link
Collaborator

Resolve numerous deprecation warnings.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b32636) 94.45% compared to head (c8b8e0e) 94.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   94.45%   94.44%   -0.02%     
==========================================
  Files          91       91              
  Lines        5662     5664       +2     
==========================================
+ Hits         5348     5349       +1     
- Misses        314      315       +1     
Flag Coverage Δ
unittests 94.44% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +6 to +11
ignore::DeprecationWarning:.*pkg_resources.*
ignore::DeprecationWarning:.*flax.*
ignore::DeprecationWarning:.*.tensorboardx.*
ignore::DeprecationWarning:.*xdesign.*
ignore:.*pkg_resources.*:DeprecationWarning
ignore:.*imp module.*:DeprecationWarning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can any of these easily be made more specific to avoid hiding future deprecation warnings from these packages?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so straightforward, but I can try.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I will do that some other time.

@bwohlberg bwohlberg merged commit 4eb21c1 into main Dec 14, 2023
19 checks passed
@bwohlberg bwohlberg deleted the brendt/deprec-warn branch December 14, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants