Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory requirements of Identity linop #501

Merged
merged 25 commits into from
Feb 15, 2024
Merged

Conversation

bwohlberg
Copy link
Collaborator

Reduce memory requirements of Identity linop, and other improvements.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1a66887) 94.77% compared to head (c22a186) 94.70%.

Files Patch % Lines
scico/linop/_diag.py 93.15% 5 Missing ⚠️
scico/linop/_matrix.py 66.67% 3 Missing ⚠️
scico/solver.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   94.77%   94.70%   -0.07%     
==========================================
  Files          91       91              
  Lines        5641     5696      +55     
==========================================
+ Hits         5346     5394      +48     
- Misses        295      302       +7     
Flag Coverage Δ
unittests 94.70% <91.67%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scico/linop/_diag.py Outdated Show resolved Hide resolved
scico/linop/_diag.py Show resolved Hide resolved
scico/linop/_diag.py Show resolved Hide resolved
scico/test/linop/test_binop.py Outdated Show resolved Hide resolved
scico/test/linop/test_diag.py Show resolved Hide resolved
Comment on lines -11 to -12
import operator
from functools import partial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@bwohlberg bwohlberg merged commit 6e46ca2 into main Feb 15, 2024
18 of 19 checks passed
@bwohlberg bwohlberg deleted the brendt/identity branch February 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants