Add diagonal operator mapping base operator over an array axis #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crstngc
approved these changes
Jun 12, 2024
Michael-T-McCann
approved these changes
Jun 25, 2024
scico/linop/_stack.py
Outdated
| @@ -146,6 +147,83 @@ def _adj(self, y: Union[Array, BlockArray]) -> Union[Array, BlockArray]: # type | |||
| return snp.blockarray(result) | |||
|
|
|||
|
|
|||
| class DiagonalReplicated(DReplicated, LinearOperator): | |||
There was a problem hiding this comment.
It takes a second to figure out what DReplicated is here. Consider DiagonalReplicatedOperator?
There was a problem hiding this comment.
I assume you noticed that this is an alias for operator.DiagonalReplicated. You don't have similar concerns for DStack and VStack? If DReplicated is changed as suggested, it would seem to make sense to modify them too for consistency.
There was a problem hiding this comment.
Addressed as discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diagonal operator mapping base operator over an array axis via
jax.pmaporjax.vmap.Resolves #413.