Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in admm.LinearSubproblemSolver #91

Closed
wants to merge 4 commits into from
Closed

Conversation

bwohlberg
Copy link
Collaborator

Fix bug in admm.LinearSubproblemSolver, resolving #90.

@bwohlberg bwohlberg added the bug Something isn't working label Nov 13, 2021
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #91 (70a041c) into main (4684909) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   90.17%   90.37%   +0.20%     
==========================================
  Files          42       42              
  Lines        2981     2981              
==========================================
+ Hits         2688     2694       +6     
+ Misses        293      287       -6     
Flag Coverage Δ
unittests 90.37% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/admm.py 89.79% <100.00%> (+1.02%) ⬆️
scico/loss.py 87.93% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4684909...70a041c. Read the comment docs.

@bwohlberg bwohlberg linked an issue Nov 13, 2021 that may be closed by this pull request
@smajee
Copy link
Contributor

smajee commented Nov 13, 2021

This fixes the error, but when I run it, the solution looks weird to me.

Screen Shot 2021-11-13 at 12 10 17 AM

@bwohlberg
Copy link
Collaborator Author

bwohlberg commented Nov 13, 2021

This fixes the error, but when I run it, the solution looks weird to me.

Resolved after fixing the error pointed out by @tbalke.

@bwohlberg bwohlberg marked this pull request as draft November 13, 2021 15:36
@bwohlberg
Copy link
Collaborator Author

Converted to draft to avoid accidental merge: this PR likely to be discarded since its branch has been merged into #88.

@bwohlberg
Copy link
Collaborator Author

Closing since all changes merged into mike/approx_prox, the branch for #88.

@bwohlberg bwohlberg closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example script ct_svmbir_ppp_bm3d_admm_cg.py broken
2 participants