Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports build integration and spiner install cleanup #22

Merged
merged 13 commits into from
Mar 7, 2022

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

This is a follow up to the work in ports-of-call. Here I:

  • add a spackage for ports-of-call into the local spiner spack repo
  • update spiner's cmake build system to look for an external ports-of-call package and use it if available
  • fix some errors in the spackage in spiner
  • have spiner output package config information for cmake so that downstream codes can FindPackage for it more easily.

In the process, I changed spiner from providing two targets: spiner::flags and spiner::libs to just providing spiner::spiner. In this case, I believe this was less cumbersome and produced a lot less cmake code.

PR Checklist

  • Code is formatted.
  • Adds a test for any bugs fixed. Adds tests for new features.

@Yurlungur Yurlungur added the enhancement New feature or request label Feb 22, 2022
@Yurlungur Yurlungur self-assigned this Feb 22, 2022
@Yurlungur
Copy link
Collaborator Author

As I am not super confident in my cmake skills, a cmake wizard should probably look over this. @mauneyc-LANL @junghans feedback welcome.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator Author

@dholladay00 @mauneyc-LANL I believe all comments have been addressed. Want to take a look?

@mauneyc-LANL
Copy link
Collaborator

@dholladay00 @mauneyc-LANL I believe all comments have been addressed. Want to take a look?

looks good to me.

@Yurlungur
Copy link
Collaborator Author

@dholladay00 @mauneyc-LANL I believe all comments have been addressed. Want to take a look?

looks good to me.

Can you click approve?

@Yurlungur Yurlungur merged commit da0697a into main Mar 7, 2022
@Yurlungur Yurlungur deleted the jmm/ports-build-integration branch March 7, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants