-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ports build integration and spiner install cleanup #22
Conversation
As I am not super confident in my cmake skills, a cmake wizard should probably look over this. @mauneyc-LANL @junghans feedback welcome. |
@dholladay00 @mauneyc-LANL I believe all comments have been addressed. Want to take a look? |
looks good to me. |
Can you click approve? |
PR Summary
This is a follow up to the work in ports-of-call. Here I:
ports-of-call
into the localspiner
spack repospiner
's cmake build system to look for an externalports-of-call
package and use it if availablespiner
output package config information for cmake so that downstream codes canFindPackage
for it more easily.In the process, I changed
spiner
from providing two targets:spiner::flags
andspiner::libs
to just providingspiner::spiner
. In this case, I believe this was less cumbersome and produced a lot less cmake code.PR Checklist