More interpolation operations #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also add raw 4D interpolation, needed for transport, and tests. Test for the indexing operation not yet complete. |
|
I also fix an edge case I hadn't encountered previously, where I use Kokkos on host only. |
Yurlungur
changed the title
|
This is now ready for review. |
dholladay00
reviewed
Jun 28, 2021
dholladay00
reviewed
Jun 28, 2021
|
Thanks for the comments, @dholladay00 I think I should have addressed everything. If i did, can you approve? |
dholladay00
approved these changes
Jun 28, 2021
This was referenced Jun 29, 2021
dholladay00
pushed a commit
that referenced
this pull request
May 26, 2023
Co-authored-by: Chad Meyer <chadmeyer@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
For
singularity-opac, I need the capability to perform interpolation of the form:where
x1,x2,x3, andx4are real numbers that are interpolated on andjis an integer that's indexed on. This is a common pattern for multi-species transport such as neutrino transport. I don't expect it's needed outside of neutrino transport, but you never know.PR Checklist