Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf version #678

Closed
nrudakov opened this issue Dec 29, 2022 · 4 comments
Closed

Protobuf version #678

nrudakov opened this issue Dec 29, 2022 · 4 comments

Comments

@nrudakov
Copy link

Any reason why protobuf version is restricted to 3.20.1?

tensorboardX/setup.py

Line 46 in 9356270

'protobuf>=3.8.0,<=3.20.1',

And can it be changed to >=3.8.0,<4 ?

The latest release of onnx requires protobuf >= 3.20.2, < 4 https://github.com/onnx/onnx/blob/ee7d2cdfa34b8b3c7e0b68b70daf72aaa48c23ac/requirements.txt#L2
Therefore, it is not possible to install both tensorboardX and onnx in the same environment without error messages.
@lanpa
Copy link
Owner

lanpa commented Jan 2, 2023

Hi, I have updated the requirement to <=3.20.3 in #675. Thank you for pointing this out so I can found this github-bot's PR. XD

louisoutin added a commit to louisoutin/tensorboardX that referenced this issue Jan 8, 2023
@louisoutin
Allow for larger version of protobuf
f6f2cb2 
onnx (1.13.0) depends on protobuf (>=3.20.2,<4)
tensorboardx (2.5.1) depends on protobuf (>=3.8.0,<=3.20.1)
==> tensorboardx not compatible with tensorboardx.
Can we just allow for a larger version of protobuf please?

(Related to lanpa#678)
@louisoutin louisoutin mentioned this issue Jan 8, 2023
Merged
@xkszltl
Copy link

xkszltl commented Jan 19, 2023

@lanpa It should be <4, not <=3.20.3, protobuf is still release new versions under 3.20, after their renaming of 3.21 to 4.21 with breaking changes.

lanpa pushed a commit that referenced this issue Jan 23, 2023
@louisoutin
Allow for larger version of protobuf (#680)
a402e19 
onnx (1.13.0) depends on protobuf (>=3.20.2,<4)
tensorboardx (2.5.1) depends on protobuf (>=3.8.0,<=3.20.1)
==> tensorboardx not compatible with tensorboardx.
Can we just allow for a larger version of protobuf please?

(Related to #678)
@lanpa
Copy link
Owner

lanpa commented Jan 25, 2023

@xkszltl Updated by @louisoutin in #680. Please have a test!

@lanpa lanpa closed this as completed Jan 25, 2023
@xkszltl
Copy link

xkszltl commented Jan 26, 2023

Should be good as it's a simple fix and I've suggested it to many libs, including the onnx one referred by @nrudakov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lanpa @xkszltl @nrudakov