Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inkplate 6PLUS features and fixes #12

Closed
wants to merge 14 commits into from
Closed

Conversation

phidauex
Copy link

Apologies for this messy pull request - still a novice at this. This request addresses a number of small fixes as well as prepares for Inkplate 6PLUS compatibility.

  • New build environment options in platform.ini (ota and debug still default to Inkplate10, but there is a custom env for the 6 plus)
  • New fonts to provide more options, including the nice "condensed" roboto
  • Touchscreen init for 6PLUS (currently only allows the touch screen to wake, but that can be expanded on later)
  • Fix to TZ name and move TZ variables up into the config_example.h file
  • Update to battery % formula including more precise voltages, and a change to the percentage calculation to prevent overflows at very low / slightly negative SOCs.
  • Some reformats to the Info display - I believe this should still look good on the Inkplate 10.

@lanrat
Copy link
Owner

lanrat commented Nov 30, 2022

Hello @phidauex, thanks for the PR!

There is a lot going on here, and I'm currently traveling so I won't be able to test this until next week. However after a
quick preliminary review, I see that you changed a few of the constants I had used to specify font sizes, pixel locations/offsets, etc.. for the Inkplate 6.

Since the Inkplate 6 and 10 have different sizes, would you be able to put your changes behind an #IFDEF to support both platforms, or where possible, use a calculation based on the E_INK_HEIGHT and E_INK_WIDTH constants that would work for both devices?

@phidauex
Copy link
Author

phidauex commented Dec 1, 2022

Let me attempt to split this PR into two (I think I can do that). That would leave one with changes to allow for basic Inkplate 6PLUS functionality and a few fixes, and then a second that reformats the Info page (in a way that I think will look better on both the 6PLUS and the 10). This is probably too much to review all together.

@phidauex phidauex closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants