Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test to make sure the bot actually starts #56

Open
egillespie opened this issue Oct 26, 2020 · 0 comments
Open

Create test to make sure the bot actually starts #56

egillespie opened this issue Oct 26, 2020 · 0 comments
Labels

Comments

@egillespie
Copy link
Contributor

Describe the bug

The current test suite makes sure functional capabilities are working, but it does not ensure that the bot actually starts up successfully. In cases where there are dependency mismatches — which can easily happen with an npm audit fix or npm outdated and Firebase — the tests run successfully, but the bot does not start.

Expected behavior

A deployment should not occur if the bot will not have a high certainty of starting. Since the test suite is required to pass before deployments can occur, a test that makes sure the bot starts and exits with a 0 status code would prevent deploying an un-startable bot.

@egillespie egillespie added the bug label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant