-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix threading issues with in-process measure evaluation (#709)
* Pre-compile with non-null subject This appears to be required for best performance. Without it, the initial batch of evaluations runs somewhat slower (still much better than with *no* pre-compilation, but an order of magnitude slower than pre-compiling with a null subject). * Fix thread-safety issue `InMemoryFhirRepository` does not appear to be thread-safe. (Concurrent calls to its `search` method have the potential to throw `ConcurrentModificationException`s.) Therefore, we shouldn't be caching it across evaluations. Instead, spin up a new repository and `R4MeasureService` for each evaluation. (Not a performance concern; we can still cache `MeasureEvaluationOptions`, which prevents us from having to recompile libraries.) * Explicitly permit `/error` route
- Loading branch information
1 parent
3a563bc
commit 0363ad5
Showing
2 changed files
with
16 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters