Add measure def existence check

lantanagroup · Feb 22, 2024 · 18543dc · 18543dc
1 parent 1799a09
commit 18543dc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/api/src/main/java/com/lantanagroup/link/api/controller/PatientIdentifierController.java b/api/src/main/java/com/lantanagroup/link/api/controller/PatientIdentifierController.java
@@ -246,9 +246,7 @@ private void checkMeasureIdentifier(ListResource list) {
     }
     Identifier measureIdentifier = list.getIdentifier().get(0);
 
-    MeasureDefinition measureDefinition = this.sharedService.getMeasureDefinition(measureIdentifier.getValue());
-
-    if (measureDefinition == null) {
+    if (this.sharedService.measureDefinitionExists(measureIdentifier.getValue())) {
       String msg = String.format("Measure %s (%s) not found on data store", measureIdentifier.getValue(), measureIdentifier.getSystem());
       logger.error(msg);
       throw new ResponseStatusException(HttpStatus.NOT_FOUND, msg);

diff --git a/core/src/main/java/com/lantanagroup/link/db/SharedService.java b/core/src/main/java/com/lantanagroup/link/db/SharedService.java
@@ -245,6 +245,25 @@ public void saveTenantConfig(Tenant tenant){
     }
   }
 
+  public boolean measureDefinitionExists(String measureId) {
+    try (Connection conn = this.getSQLConnection()) {
+      assert conn != null;
+
+      PreparedStatement ps = conn.prepareStatement("SELECT COUNT(*) FROM [dbo].[measureDef] WHERE measureId = ?");
+      ps.setNString(1, measureId);
+
+      ResultSet rs = ps.executeQuery();
+
+      if (rs.next()) {
+        return rs.getInt(1) > 0;
+      }
+
+      return false;
+    } catch (SQLException | NullPointerException e) {
+      throw new RuntimeException(e);
+    }
+  }
+
   public MeasureDefinition getMeasureDefinition(String measureId) {
     try (Connection conn = this.getSQLConnection()) {
       assert conn != null;