Misc improvements to Device generation #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping track of ImplementationGuide resources found in NpmPackages within the `Validator` separately from the `PrePopulatedValidationSupport` since `PrePopulatedValidationSupport` doesn't do anything with ImplementationGuide Loading Device.notes with list of implementation guides that are loaded at the time of validation Update Device.notes in the report when a report is re-validated Changing interface for IPatientIdProvider to not return the patient list, since it just loads it into the report context anyways and the return value isn't used. Change `Device` generated to use `note` for events and concept maps. Much more readable. Conferred with Karen and Dave, who agreed.
smailliwcs
approved these changes
Mar 1, 2024
api/src/main/java/com/lantanagroup/link/api/controller/ValidationController.java
Show resolved
Hide resolved
core/src/main/java/com/lantanagroup/link/validation/Validator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/lantanagroup/link/validation/Validator.java
Outdated
Show resolved
Hide resolved
….json Not logging parse errors in LenientErrorHandler. We only care if there's an exception, and we're catching and logging those anyways. Bringing the IG status forward from the original IG. Parsing resources from packages using a stream instead of loading a string up first. Handling exception during parsing a little nicer for logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validatorseparately from thePrePopulatedValidationSupportsincePrePopulatedValidationSupportdoesn't do anything with ImplementationGuideDevicegenerated to usenotefor events and concept maps. Much more readable. Conferred with Karen and Dave, who agreed.