LNK-1871: Some refactors to the FileSystemSender. Also, updates to an… #716
Conversation
…notate validation results with what file each issue listed in the results comes from when the not a Bundle flag is set in the sender configuration and saves said results to the same location as the rest of the bundle files.
There was a problem hiding this comment.
Consider re-formatting/indenting the file as a whole... Noticed a couple weird indentations.
Also consider (not required by this ticket, though) modifying the folder that's exported to so that it is based on <tenant's-nhsn-org-id>-<date-time-stamp>. For example: 43242-20240307T095900+0800 where 43242 is the nhsnOrgId in the tenant's config. Again, not required for this ticket, but I think it would be ideal, if it can be squeezed in.
core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
One additional general comment: the validation issue expressions reflect locations in the "unified bundle" (since that's what we actually perform validation on). So when we saveToFolder, and all those bundled resources get split out into separate files, the expressions are no longer accurate. Not sure how big of a problem this is.
core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
Outdated
Show resolved
Hide resolved
… some minor refactors.
core/src/main/java/com/lantanagroup/link/FhirBundleProcessor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
Outdated
Show resolved
Hide resolved
…lization block per the PR.
…of being done each time filterResourcesByPathList is called
…notate validation results with what file each issue listed in the results comes from when the not a Bundle flag is set in the sender configuration and saves said results to the same location as the rest of the bundle files.