Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNK-2186 Validation category and results details HTML output #721

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

seanmcilvenna
Copy link
Contributor

  • Moving ValidationCategorizer to the validation package.
  • Adding unit test to ensure unique category ids are specified.
  • Updates to categories to de-duplicate them, fixing the naming/guidance on at least one of them.
  • Add text/html output for the validation category results endpoint that produces an HTML file that can be downloaded and opened in a browser, showing the categories and validation result details.
  • Moving some logic for categorizing from the controller to ValidationCategorizer.
  • Adding validation-results.html as output in the folder-based submission so that they can be automatically generated and included in the submission for review.

Adding unit test to ensure unique category ids are specified.
Updates categories to de-duplicate them, fixing the naming/guidance on at least one of them.
Add text/html output for the validation category results endpoint that produces an HTML file that can be downloaded and opened in a browser, showing the categories and validation result details.
Moving some logic for categorizing from the controller to `ValidationCategorizer`.
Adding validation-results.html as output in the folder-based submission so that they can be automatically generated and included in the submission for review.
@seanmcilvenna seanmcilvenna mentioned this pull request Mar 14, 2024
# Conflicts:
#	core/src/main/java/com/lantanagroup/link/sender/FileSystemSender.java
@seanmcilvenna seanmcilvenna merged commit 268132d into development Mar 15, 2024
2 of 3 checks passed
@seanmcilvenna seanmcilvenna deleted the LNK-2186 branch March 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants