Lnk 2116 logging improvements #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcilvenna
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Generally looks good. Would like to know if the reportId gets populated into logging_event_property table (or whatever it's called)... Ultimately would like to be able to perform the following select, if at all possible:
SELECT * FROM logging_event e JOIN logging_event_property p ... WHERE p.name = 'reportId' and p.value = '12345'
smailliwcs
requested changes
Apr 11, 2024
api/src/main/java/com/lantanagroup/link/api/controller/ReportController.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/lantanagroup/link/api/controller/ReportController.java
Outdated
Show resolved
Hide resolved
smailliwcs
approved these changes
Apr 12, 2024
MDC values are available in the `logging_event_property` table, so there's no need to explicitly inject them into the formatted message.
Additionally, make this information available via the console and file appenders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.