Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int overflow issue for progress #186

Merged
merged 2 commits into from Oct 1, 2023
Merged

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Oct 1, 2023

As the progress was int32, the progress was overflowing if index is bigger than ~2GB.

@var77 var77 requested a review from Ngalstyan4 October 1, 2023 20:40
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #186 (545c4ae) into main (29af187) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files          17       17           
  Lines        1201     1201           
  Branches      256      256           
=======================================
  Hits          998      998           
  Misses         81       81           
  Partials      122      122           
Files Coverage Δ
src/hnsw/external_index.c 91.09% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.774 0.758 -2.07%
select bulk tps 221.794 236.280 +6.53%
select bulk latency (ms) 34.222 30.683 -10.34%
select bulk latency (stddev ms) 10.459 13.949 +33.37%
create latency (ms) 1458.342 1565.197 +7.33%
insert bulk tps 13.953 14.122 +1.21%
insert bulk latency (ms) 71.652 70.799 -1.19%
insert bulk latency (stddev ms) 6.077 2.105 -65.36%
disk usage (bytes) 6348800.000 6348800.000 -

@var77 var77 force-pushed the varik/progress-int-overflow branch from 62bd3df to 545c4ae Compare October 1, 2023 21:18
@Ngalstyan4 Ngalstyan4 merged commit 57876ef into main Oct 1, 2023
27 checks passed
@Ngalstyan4 Ngalstyan4 deleted the varik/progress-int-overflow branch October 1, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants