Narek/release0.0.12 #265
Narek/release0.0.12 #265
Conversation
Benchmarks
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 81.72% 77.68% -4.05%
==========================================
Files 17 23 +6
Lines 1538 1963 +425
Branches 346 492 +146
==========================================
+ Hits 1257 1525 +268
- Misses 126 226 +100
- Partials 155 212 +57
|
Add support to "latest" in Version class repr for version
Ngalstyan4
force-pushed
the
narek/release0.0.12
branch
from
80bd2db
to
3ff1409
Compare
…atch to allow update scripts that rebuild the index
Ngalstyan4
force-pushed
the
narek/release0.0.12
branch
from
3ff1409
to
166d85d
Compare
CMakeLists.txt
Outdated
| @@ -311,7 +333,7 @@ if (CLANG_FORMAT) | |||
|
|
|||
| string(REGEX MATCH "[0-9]+\\.[0-9]+\\.[0-9]+" CLANG_FORMAT_VERSION "${CLANG_FORMAT_VERSION}") | |||
|
|
|||
| if(CLANG_FORMAT_VERSION VERSION_LESS 14) | |||
| if(CLANG_FORMAT_VERSION VERSION_LESS 13) | |||
| message(WARNING "clang-format version ${CLANG_FORMAT_VERSION} found, need at least 14") | |||
There was a problem hiding this comment.
Should we change the version number in error message as well?
| @@ -177,6 +177,17 @@ bool VersionsMatch() | |||
| version_checked = true; | |||
|
|
|||
| SPI_finish(); | |||
|
|
|||
| if(!versions_match) { | |||
| elog(WARNING, | |||
There was a problem hiding this comment.
Do we need the elog to be moved here? As now we will have duplicate logs for build and insert (as they're changed to WARNING) right?
There was a problem hiding this comment.
this is logged once, as otherwise versions_match is cached.
it is good to have here for debugging, since it actually prints the version names and tells something about what the mismatch is
No description provided.