Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Exit with non-zero error code in error cases of install script #269

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Ngalstyan4
Copy link
Contributor

Without this, an installation from binary file returns zero, indicating success.
This led us believe that ARM binaries were distributed in releases when building lantern-suite in ci/cd here:
https://github.com/lanterndata/lantern-suite/actions/runs/7631627710/job/20790001102#step:6:3777

Without this, an installation from binary file returns zero, indicating
success.
This led us believe that ARM binaries were distributed in releases
when building lantern-suite in ci/cd here:
https://github.com/lanterndata/lantern-suite/actions/runs/7631627710/job/20790001102#step:6:3777
@Ngalstyan4 Ngalstyan4 requested a review from var77 January 25, 2024 06:03
Copy link

Benchmarks

metric old new pct change
recall (after create) 0.992 0.992 -
recall (after insert) 0.992 0.992 -
select tps 5641.351 5352.125 -5.13%
select bulk(100) tps 50.989 50.919 -0.14%
select latency (ms) 4.532 ± 2.503𝜎 4.668 ± 2.853𝜎 +3.00%
select bulk(100) latency (ms) 622.385 ± 17.634𝜎 619.085 ± 28.435𝜎 -0.53%
create latency (ms) 1296.668 1249.267 -3.66%
insert tps 1585.625 1571.654 -0.88%
insert bulk(100) tps 20.727 21.293 +2.73%
insert latency (ms) 19.610 ± 7.912𝜎 19.704 ± 7.651𝜎 +0.48%
insert bulk(100) latency (ms) 1128.861 ± 362.294𝜎 1128.656 ± 304.916𝜎 -0.02%
disk usage (bytes) 6348800.000 6348800.000 -

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23690ec) 77.68% compared to head (c50fa78) 77.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files          23       23           
  Lines        1963     1963           
  Branches      492      492           
=======================================
  Hits         1525     1525           
  Misses        226      226           
  Partials      212      212           

@Ngalstyan4 Ngalstyan4 merged commit 1e44ac4 into main Jan 25, 2024
32 of 33 checks passed
@Ngalstyan4 Ngalstyan4 deleted the narek/exit-non-zero branch January 25, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants