Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narek/async tasks jobid fix #316

Merged
merged 10 commits into from
May 2, 2024
Merged

Narek/async tasks jobid fix #316

merged 10 commits into from
May 2, 2024

Conversation

Ngalstyan4
Copy link
Contributor

No description provided.

@Ngalstyan4
Reproduce bug on jobid mismatch between lantern.tasks and pg_cron
8b1cbea 
Recreates the bug where succeeded lantern tasks would not have their
status updated because of a bad update query that confused
lantern.task's jobid column and cron's jobid column
dqii
dqii reviewed Apr 29, 2024
View reviewed changes
test/sql/async_tasks.sql Outdated Show resolved Hide resolved
@Ngalstyan4 Ngalstyan4 force-pushed the narek/async-tasks-jobid-fix branch 2 times, most recently from 2646832 to 7c756ef Compare April 29, 2024 01:22
@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

5 similar comments
@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/hnsw/delete.c 90.00% 0 Missing and 2 partials ⚠️
src/hnsw/external_index.c 71.42% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

17 similar comments
@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 force-pushed the narek/async-tasks-jobid-fix branch from 9cefb80 to 8fe7603 Compare May 2, 2024 05:05
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

9 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

9 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 merged commit bdce633 into main May 2, 2024
41 of 45 checks passed
@Ngalstyan4 Ngalstyan4 deleted the narek/async-tasks-jobid-fix branch May 2, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqii dqii dqii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ngalstyan4 @dqii