Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hover hints + show multiple hover hint items #1381

Merged
merged 4 commits into from Sep 28, 2022
Merged

Fix hover hints + show multiple hover hint items #1381

merged 4 commits into from Sep 28, 2022

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Sep 27, 2022 •
edited

Changes:

  • fixes hover hints (currently broken on master
  • adds support for multiple hover items
  • adds padding at top of hover box
  • filters out empty hints

Before:

Screenshot 2022-09-27 at 22 51 08

After:

Screenshot 2022-09-27 at 22 52 40

(the syntax highlighting being broken isn't related to this PR)

bugadani
bugadani reviewed Sep 28, 2022
View reviewed changes
lapce-data/src/hover.rs Outdated Show resolved Hide resolved
bugadani
bugadani reviewed Sep 28, 2022
View reviewed changes
lapce-data/src/hover.rs Outdated Show resolved Hide resolved
@camc314 camc314 force-pushed the cam/dev/show-hover-data-lists branch from 0a87bfc to 12666d7 Compare September 28, 2022 07:46
@camc314 camc314 marked this pull request as ready for review September 28, 2022 18:06
@dzhou121 dzhou121 merged commit cdc6abb into lapce:master Sep 28, 2022
@MinusGix MinusGix mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugadani bugadani bugadani left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camc314 @bugadani @dzhou121