New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open editors list can now be collapsed by clicking it #1574
Open editors list can now be collapsed by clicking it #1574
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
=========================================
+ Coverage 8.48% 9.05% +0.56%
=========================================
Files 130 131 +1
Lines 56586 57006 +420
=========================================
+ Hits 4804 5160 +356
- Misses 51782 51846 +64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for adding this. Would you like to extend it for all |
Sure, but i should probably add some icons to indicate that its expandable. Something like a down_arrow.svg. |
https://github.com/lapce/lapce/blob/master/icons/codicons/chevron-down.svg |
37f6a72
to
7304930
Compare
I would suggest putting the size 0 logic in PanelSection. |
@dzhou121 so every one of these panel must have a pointer (WidgetId i guess) to their PanelSection and send commands that way? |
Would be nice if this could be made persistent - I'd like to never have open editors show up, this would make me collapse the panel every time I open lapce. This also solves #1114 |
@dzhou121 I've gotten around to reimplementing it as you requested. |
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
2a1d4fe
to
162c7a3
Compare
Thanks! |
Partially solves: #1398
Signed-off-by: Hanif Bin Ariffin hanif.ariffin.4326@gmail.com
CHANGELOG.md
if this change could be valuable to users