Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open editors list can now be collapsed by clicking it #1574

Merged

Conversation

hbina
Copy link
Contributor

@hbina hbina commented Oct 22, 2022

Partially solves: #1398

Signed-off-by: Hanif Bin Ariffin hanif.ariffin.4326@gmail.com

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #1574 (2a1d4fe) into master (a9bee50) will increase coverage by 0.56%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1574      +/-   ##
=========================================
+ Coverage    8.48%   9.05%   +0.56%     
=========================================
  Files         130     131       +1     
  Lines       56586   57006     +420     
=========================================
+ Hits         4804    5160     +356     
- Misses      51782   51846      +64     
Impacted Files Coverage Δ
lapce-data/src/command.rs 0.00% <ø> (ø)
lapce-ui/src/explorer.rs 0.00% <0.00%> (ø)
lapce-ui/src/panel.rs 0.00% <0.00%> (ø)
lapce-ui/src/plugin.rs 0.00% <0.00%> (ø)
lapce-ui/src/problem.rs 0.00% <0.00%> (ø)
lapce-ui/src/search.rs 0.00% <0.00%> (ø)
lapce-ui/src/source_control.rs 0.00% <0.00%> (ø)
lapce-ui/src/terminal.rs 0.00% <0.00%> (ø)
lapce-ui/src/editor/tab_header_content.rs 12.50% <0.00%> (-0.06%) ⬇️
lapce-data/src/palette.rs 4.16% <0.00%> (-0.03%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MinusGix MinusGix added the A-ui Area: UI rendering and interactions label Oct 22, 2022
@dzhou121
Copy link
Collaborator

Thanks for adding this. Would you like to extend it for all PanelSectionHeader?

@hbina
Copy link
Contributor Author

hbina commented Oct 23, 2022

Sure, but i should probably add some icons to indicate that its expandable. Something like a down_arrow.svg.

@panekj
Copy link
Collaborator

panekj commented Oct 23, 2022

Sure, but i should probably add some icons to indicate that its expandable. Something like a down_arrow.svg.

https://github.com/lapce/lapce/blob/master/icons/codicons/chevron-down.svg
https://github.com/lapce/lapce/blob/master/icons/codicons/chevron-right.svg

@dzhou121
Copy link
Collaborator

I would suggest putting the size 0 logic in PanelSection.

@hbina
Copy link
Contributor Author

hbina commented Dec 15, 2022

@dzhou121 so every one of these panel must have a pointer (WidgetId i guess) to their PanelSection and send commands that way?

@panekj panekj mentioned this pull request Dec 17, 2022
1 task
@Gerrit0
Copy link

Gerrit0 commented Dec 17, 2022

Would be nice if this could be made persistent - I'd like to never have open editors show up, this would make me collapse the panel every time I open lapce.

This also solves #1114

@hbina
Copy link
Contributor Author

hbina commented Jan 5, 2023

@dzhou121 I've gotten around to reimplementing it as you requested.

Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
@hbina hbina force-pushed the hbina-able-to-collapse-open-editors-list branch from 2a1d4fe to 162c7a3 Compare January 5, 2023 05:11
@dzhou121
Copy link
Collaborator

dzhou121 commented Jan 5, 2023

Thanks!

@dzhou121 dzhou121 merged commit 0d9bb93 into lapce:master Jan 5, 2023
@panekj panekj added this to the Next release milestone Jan 5, 2023
@hbina hbina deleted the hbina-able-to-collapse-open-editors-list branch January 5, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: UI rendering and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants