Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: new windows would never be created after closing all #1651

Merged
merged 2 commits into from Nov 6, 2022
Merged

Fix: new windows would never be created after closing all #1651

merged 2 commits into from Nov 6, 2022

Conversation

I-Info
Copy link
Contributor

@I-Info I-Info commented Nov 6, 2022

  • Added an entry to CHANGELOG.md if this change could be valuable to users

Fixed: #1588

The `NewWindow`Command submitted by
`Event::ApplicationShouldHandleReopen`
will never be handled before `update()`.
@dzhou121 dzhou121 merged commit a65ab0b into lapce:master Nov 6, 2022
@I-Info I-Info deleted the macos-handle-reopen branch November 6, 2022 23:40
Copy link
Contributor Author

@I-Info I-Info left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an inappropriate link in the CHANGELOG.md

CHANGELOG.md Show resolved Hide resolved
@panekj panekj added this to the Next release milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activate window num is wrong
3 participants