Fix cursor movement on selections with arrow keys #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinusGix
force-pushed
the
selection-arrow-keys
branch
2 times, most recently
from
434e227
to
aadd749
Compare
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
=========================================
- Coverage 8.49% 8.48% -0.01%
=========================================
Files 130 130
Lines 56586 56597 +11
=========================================
Hits 4805 4805
- Misses 51781 51792 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif this change could be valuable to usersFixes #1908
(Where
|is the cursor and|H|is a selection)Before:
|H|ello-> right arrow key ->He|llo|H|ello-> right arrow key ->H|elloThis matches other applications better.
It would be nice to have tests for this, but I didn't see testing code for the document movement commands?