Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register buffer when saving-as a new file #1939

Merged
merged 1 commit into from Jan 8, 2023

Conversation

MinusGix
Copy link
Member

@MinusGix MinusGix commented Jan 8, 2023

  • Added an entry to CHANGELOG.md if this change could be valuable to users

Fixes #1750
The issue was that the new file was not registered, thus causing future attempts to update the file to error.

@MinusGix MinusGix added the C-bug Category: bug - something isn't working as it's supposed to label Jan 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Merging #1939 (caea297) into master (a49e354) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1939      +/-   ##
=========================================
- Coverage    9.04%   9.04%   -0.01%     
=========================================
  Files         131     131              
  Lines       57051   57052       +1     
=========================================
  Hits         5160    5160              
- Misses      51891   51892       +1     
Impacted Files Coverage Δ
lapce-proxy/src/dispatch.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzhou121
Copy link
Collaborator

dzhou121 commented Jan 8, 2023

Good catch!

@dzhou121 dzhou121 merged commit 45c78e8 into lapce:master Jan 8, 2023
@panekj panekj added this to the Next release milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug - something isn't working as it's supposed to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly created file cannot be saved
4 participants