Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lang): Add sticky headers and code lens for PHP #1960

Merged
merged 2 commits into from Jan 11, 2023
Merged

feat(lang): Add sticky headers and code lens for PHP #1960

merged 2 commits into from Jan 11, 2023

Conversation

claytonrcarter
Copy link
Contributor

@claytonrcarter claytonrcarter commented Jan 11, 2023 •
edited

  • Added an entry to CHANGELOG.md if this change could be valuable to users

Adds 2 things:

  • tree-sitter configuration for sticky headers and code lens in PHP files.
  • docstrings for how code lenses are built (satisfies an existing TODO)

Current behavior in the Laravel Request class:
Screen Shot 2023-01-10 at 9 22 03 PM
Screen Shot 2023-01-10 at 9 22 12 PM

Behavior in this PR:
Screen Shot 2023-01-10 at 9 22 35 PM
Screen Shot 2023-01-10 at 9 23 00 PM

@claytonrcarter claytonrcarter marked this pull request as ready for review January 11, 2023 03:19
@dzhou121 dzhou121 merged commit 1c57875 into lapce:master Jan 11, 2023
@panekj panekj added this to the Next release milestone Jan 11, 2023
@MinusGix MinusGix added the A-editor Area: editor, modal editing label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-editor Area: editor, modal editing
Projects
None yet
Milestone
v0.2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@claytonrcarter @dzhou121 @MinusGix @panekj