Implement file duplication

[alvra]

This PR implements duplicating files in the fs tree context menu.

[panekj]

I don't think adding duplication is a proper thing to do, I'd rather see Copy/Paste/Cut actions like in standard file explorers

[alvra]

What would be the difference between file duplication and copy? Do you mean copy to clipboard?

[panekj]

What would be the difference between file duplication and copy?

Duplication implements very specific action which can be replaced by clipboard actions

Do you mean copy to clipboard?

Yes

[dzhou121]

I personally feel it's a good addition to copy/paste/cut, because I often do copy and paste which is essentially duplicate.

[panekj]

I personally feel it's a good addition to copy/paste/cut, because I often do copy and paste which is essentially duplicate.

It's not bad per se, but I would like to avoid adding it to mouse context menu. As we develop we will be adding more actions which could be more useful and cluttering context menu with too many actions feels wrong.

[alvra]

True, duplication is more specific than copy+paste. Personally I use duplicate much more often and having it as a single option is helpful to me. New files often share code with its siblings so I probably use duplicate more even than "new empty file".

[dzhou121]

I personally feel it's a good addition to copy/paste/cut, because I often do copy and paste which is essentially duplicate.

It's not bad per se, but I would like to avoid adding it to mouse context menu. As we develop we will be adding more actions which could be more useful and cluttering context menu with too many actions feels wrong.

I don't feel it would be too much with one more menu item in the copy/paste/cut section(in the future).

[panekj]

New files often share code with its siblings so I probably use duplicate more even than "new empty file".

We should probably hide New ... when targeting files like VSCode and show it on directories/empty space only

[dzhou121]

New files often share code with its siblings so I probably use duplicate more even than "new empty file".

We should probably hide New ... when targeting files like VSCode and show it on directories/empty space only

Yeah in a separate PR maybe.

[panekj]

I personally feel it's a good addition to copy/paste/cut, because I often do copy and paste which is essentially duplicate.

It's not bad per se, but I would like to avoid adding it to mouse context menu. As we develop we will be adding more actions which could be more useful and cluttering context menu with too many actions feels wrong.

I don't feel it would be too much with one more menu item in the copy/paste/cut section(in the future).

If we're not going to implement custom context actions from plugins, then yes, it should stay fine but that's quite a limitation IMO

[codecov-commenter]

Codecov Report

Merging #1972 (94e6af1) into master (acf1de5) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1972      +/-   ##
=========================================
- Coverage    8.95%   8.93%   -0.03%     
=========================================
  Files         133     133              
  Lines       57597   57769     +172     
=========================================
+ Hits         5160    5161       +1     
- Misses      52437   52608     +171     

Impacted Files	Coverage Δ
lapce-data/src/command.rs	0.00% <ø> (ø)
lapce-data/src/explorer.rs	0.00% <0.00%> (ø)
lapce-proxy/src/dispatch.rs	0.00% <0.00%> (ø)
lapce-rpc/src/proxy.rs	0.00% <0.00%> (ø)
lapce-ui/src/explorer.rs	0.00% <0.00%> (ø)
lapce-ui/src/tab.rs	0.00% <0.00%> (ø)
lapce-data/src/keypress/keypress.rs	73.23% <0.00%> (+0.20%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dzhou121]

Can you please resolve the CHANGELOG.md conflict?