Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Rename Symbol' option on right-click #2045

Merged
merged 1 commit into from Jan 22, 2023

Conversation

ArniDagur
Copy link
Contributor

Fixes #1949

Implementation suggested by #1949 (comment). I have confirmed that with this patch I can right click to rename a symbol.

},
enabled: true,
}),
MenuKind::Separator,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added separator to match the right click item organization in VSCode.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

Merging #2045 (6408c5a) into master (13db955) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #2045      +/-   ##
=========================================
- Coverage    9.00%   9.00%   -0.01%     
=========================================
  Files         135     135              
  Lines       58822   58831       +9     
=========================================
  Hits         5295    5295              
- Misses      53527   53536       +9     
Impacted Files Coverage Δ
lapce-ui/src/editor.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@panekj panekj merged commit 5b2d412 into lapce:master Jan 22, 2023
@panekj panekj added this to the Next release milestone Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename symbol in right click menu
3 participants