Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add basic Vim marks feature #2403

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

emiosproj
Copy link
Contributor

@emiosproj emiosproj commented May 25, 2023

Adds CreateMark and GoToMark functionality, but only the local version: e.g. within the current buffer. (no global marks yet).
Will add an entry to the changelog.md if everything is fine with MR

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@panekj panekj marked this pull request as draft May 25, 2023 19:58
@panekj panekj changed the title Feature: Add basic Vim marks feature[WIP][FIRST MR] Feature: Add basic Vim marks feature May 25, 2023
@dzhou121 dzhou121 marked this pull request as ready for review May 25, 2023 20:01
Adds CreateMark and GoToMark funcitonality, but only local version:
e.g. within current buffer. (no global marks yet).
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2403 (ede8843) into master (e7f9261) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #2403      +/-   ##
=========================================
- Coverage    9.17%   9.16%   -0.01%     
=========================================
  Files         137     137              
  Lines       59537   59576      +39     
=========================================
  Hits         5462    5462              
- Misses      54075   54114      +39     
Impacted Files Coverage Δ
lapce-core/src/command.rs 0.00% <ø> (ø)
lapce-data/src/data.rs 0.00% <0.00%> (ø)
lapce-data/src/editor.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzhou121 dzhou121 merged commit 664b664 into lapce:master May 25, 2023
8 of 10 checks passed
@panekj panekj added this to the Next release milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants