Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send diagnostics capabilities for LSP #2650

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

SuperAuguste
Copy link
Contributor

@SuperAuguste SuperAuguste commented Oct 6, 2023

Previously, Lapce was not sending the right LSP capabilities, leading to language servers like the Zig Language Server to not send any diagnostics.

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@SuperAuguste SuperAuguste force-pushed the auguste/fix-lsp-not-support-diag branch from 7ce0f44 to 0053035 Compare October 6, 2023 05:13
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2650 (0053035) into master (d1c1aaf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
- Coverage   11.79%   11.79%   -0.01%     
==========================================
  Files         141      141              
  Lines       44123    44127       +4     
==========================================
  Hits         5204     5204              
- Misses      38919    38923       +4     
Files Coverage Δ
lapce-proxy/src/plugin/mod.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@panekj panekj merged commit f724016 into lapce:master Oct 6, 2023
8 of 10 checks passed
@SuperAuguste SuperAuguste deleted the auguste/fix-lsp-not-support-diag branch October 6, 2023 14:44
@panekj panekj added this to the Next release milestone Oct 8, 2023
flukejones pushed a commit to flukejones/lapce that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants