Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# tree-sitter language #273

Closed
wants to merge 3 commits into from
Closed

Add C# tree-sitter language #273

wants to merge 3 commits into from

Conversation

Tiggilyboo
Copy link

Created accompanying tree sitter support issue (Encompasses all languages) should anyone else want to tick some of these off.

Let me know if I should have approached this differently.

Cheers

@bugadani bugadani added S-conflicts Status: this PR has merge conflicts that need to be resolved C-feature Category: New feature or request labels Apr 3, 2022
@bugadani

This comment was marked as outdated.

@bugadani bugadani added the S-waiting-for-author Status: waiting for author to address review comments label Apr 19, 2022
@bugadani
Copy link
Contributor

bugadani commented Apr 19, 2022

From the experience we had with these kind of PRs, I think it would be better to add tree-sitter packages in batches. Each one of these causes at least one merge conflict that needs to be manually resolved, which is far from optimal.

I would also prefer rebasing rather than merging from master, as in my opinion that results in a nicer commit history (really, a merge isn't part of the set of proposed changes, it's just a side effect), but we don't really have rules here, so it's just me. :)

@bugadani bugadani removed S-waiting-for-author Status: waiting for author to address review comments S-conflicts Status: this PR has merge conflicts that need to be resolved labels Apr 19, 2022
@bugadani bugadani requested a review from dzhou121 April 19, 2022 18:36
@bugadani
Copy link
Contributor

Whoops, sorry for the ping, I didn't notice this doesn't compile because of the upstream crate.

@ghishadow
Copy link
Contributor

Looks like upstream has merged PR, though this PR might need rebase

@bugadani
Copy link
Contributor

bugadani commented Sep 9, 2022

Closing because #1104 was merged

@bugadani bugadani closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants