Implement arbitrary theme variables #3069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if this change could be valuable to usersThis PR implements (sortof reimplements) a feature I've wanted for a while as it makes themes significantly easier to write & customize.
Rather than having base colors, we have general purpose variables that themes provide. These are prefixed with
$
.I've also modified the default themes to have a few extra variables for common patterns in them.
$secondary-background
and then we add a new view that uses$secondary-background
, it will still be consistent with the theme. (because it falls back to default color= "$secondary-background"
which is checked against the current theme first)Possible future improvements:
alpha($primary-background, 0x60)
and similar would allow variables to work even better, but do add some parsing complexity.