Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foldable panel sections #3086

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Foldable panel sections #3086

merged 1 commit into from
Mar 19, 2024

Conversation

MinusGix
Copy link
Member

@MinusGix MinusGix commented Mar 18, 2024

  • Added an entry to CHANGELOG.md if this change could be valuable to users

This PR allows you to fold panel sections. It also introduces a PanelBuilder structure to share the logic between different panels, which can hopefully be extended in the future to allow resizing panel sections.

image

image

This does have an issue when folding the panel when it is on the bottom that I'm not 100% on how to fix. It makes so the one that is folded takes more space...

@MinusGix MinusGix added the A-ui Area: UI rendering and interactions label Mar 18, 2024
@MinusGix MinusGix marked this pull request as ready for review March 18, 2024 20:53
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 210 lines in your changes are missing coverage. Please review.

Project coverage is 5.92%. Comparing base (43b54d0) to head (c29e5e5).
Report is 41 commits behind head on master.

Files Patch % Lines
lapce-app/src/panel/view.rs 0.00% 112 Missing ⚠️
lapce-app/src/app.rs 0.00% 49 Missing ⚠️
lapce-app/src/panel/debug_view.rs 0.00% 16 Missing ⚠️
lapce-app/src/panel/problem_view.rs 0.00% 14 Missing ⚠️
lapce-app/src/file_explorer/view.rs 0.00% 11 Missing ⚠️
lapce-app/src/panel/plugin_view.rs 0.00% 4 Missing ⚠️
lapce-app/src/panel/source_control_view.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3086      +/-   ##
=========================================
- Coverage    6.01%   5.92%   -0.10%     
=========================================
  Files         122     122              
  Lines       42703   43413     +710     
=========================================
+ Hits         2569    2572       +3     
- Misses      40134   40841     +707     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzhou121 dzhou121 merged commit f4a89ea into lapce:master Mar 19, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: UI rendering and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants