Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containers #3312

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Remove containers #3312

merged 2 commits into from
Jun 9, 2024

Conversation

jrmoulton
Copy link
Contributor

@jrmoulton jrmoulton commented Jun 9, 2024

  • Added an entry to CHANGELOG.md if this change could be valuable to users

This:

  • Removes more of the extra containers
  • Adds more debug names
  • Removes drawing the scroll bar background in the editor view so that the editor view is consistent with the other tab views.

I've also made an opinionated change to the design of the border on editor tabs. They now fill the full height of the tab bar. This looks more clear and less busy to me, but that's just my opinion and if people actually prefer the old way I can make it configurable.
image

Also fixes 2883 which had been previously implemented but was not responding the config changes.
I misread that issue. But now editor tab close button responds to config changes

@panekj panekj merged commit a0316a1 into lapce:master Jun 9, 2024
7 checks passed
@dzhou121
Copy link
Collaborator

dzhou121 commented Jun 9, 2024

Could you please make the editor tab border configurable?

@jrmoulton jrmoulton deleted the remove-containers branch June 9, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants