Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make showing tab forward/back configurable #3323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jrmoulton
Copy link
Contributor

  • Added an entry to CHANGELOG.md if this change could be valuable to users

@panekj
Copy link
Collaborator

panekj commented Jun 12, 2024

Is there a reason for that setting?

@jrmoulton
Copy link
Contributor Author

Just that I'd like to be able to disable it. If it's not general enough to include I'll just keep it in my fork.

@jrmoulton
Copy link
Contributor Author

There are a few settings as well for disabling parts of the UI to simplify things that I want to add. But same thing for those, if they aren't general enough to include I can just maintain them in a fork

@jrmoulton jrmoulton marked this pull request as draft June 12, 2024 06:03
@dzhou121
Copy link
Collaborator

I think let's "clutter" the config before we figure out a better way to do it.

@dzhou121 dzhou121 marked this pull request as ready for review June 12, 2024 09:22
@panekj
Copy link
Collaborator

panekj commented Jun 12, 2024

As I mention on Discord, I'd prefer for it to make it an enum option of Left, Right, Off for all buttons together (Forward/Back/New/Close)

@jrmoulton
Copy link
Contributor Author

As I mention on Discord, I'd prefer for it to make it an enum option of Left, Right, Off for all buttons together (Forward/Back/New/Close)

Makes sense to me

@jrmoulton
Copy link
Contributor Author

I tried changing these configs to part of an enum but that also included adding the dropdown configuration which adds more clutter and it wasn't better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants