Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build completely static lapce-proxy #909

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Jul 31, 2022

fixes #308

@dzhou121
Copy link
Collaborator

would be musl build be slower?

@panekj
Copy link
Collaborator Author

panekj commented Jul 31, 2022

You mean in CI or like running?

Test build is here: https://github.com/panekj/lapce/runs/7598674899

@dzhou121
Copy link
Collaborator

I meant running

@panekj
Copy link
Collaborator Author

panekj commented Jul 31, 2022

I don't see any reason why would it be slower

@dzhou121
Copy link
Collaborator

something about the memory allocation?

@panekj
Copy link
Collaborator Author

panekj commented Jul 31, 2022

musl-1.2.1.tar.gz (sig) - August 4, 2020
This release features the new "mallocng" malloc implementation, replacing musl's original dlmalloc-like allocator that suffered from fundamental design problems. Its major user-facing new properties are the ability to return freed memory on a much finer granularity and avoidance of many catastrophic fragmentation patterns. In addition it provides strong hardening against memory usage errors by the caller, including detection of overflows, double-free, and use-after-free, and does not admit corruption of allocator state via these errors.

@panekj
Copy link
Collaborator Author

panekj commented Jul 31, 2022

There might be performance difference between jemalloc and mallocng if lapce-proxy heavily relies on allocating, and I could try to link to jemalloc statically but IMO, slightly degrading performance in comparison to having universally working proxy on all Linux x64 is worth it.

@MinusGix MinusGix added the A-dev Area: general development experience within Lapce codebase label Jul 31, 2022
@panekj
Copy link
Collaborator Author

panekj commented Aug 2, 2022

@dzhou121 dzhou121 merged commit 8dc9d5b into lapce:master Aug 2, 2022
@panekj panekj deleted the patch-1 branch August 2, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dev Area: general development experience within Lapce codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh not connecting
3 participants