Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner hover icon for current selected node #81

Closed
wants to merge 2 commits into from

Conversation

olibu
Copy link
Contributor

@olibu olibu commented Jan 29, 2024

This is a small fix to highlight to current selected node without hiding the object type.
Additionally to that the highlight is set in case of hovering at the hex view, too.

It now looks like this:
image

@lapo-luchini
Copy link
Owner

That red icon was a leftover of an experiment to have a hover-menu to click upon, was never intended to be there. I recently removed it with the "context menu" #82 changes.
I also added some bgcolor highlight in 6052316.
Do you think this is still needed?
If you have suggestions, can you base them on latest code from esm branch?
Thanks!

@olibu
Copy link
Contributor Author

olibu commented Apr 8, 2024

I don't think that this is required any more as of the current esm branch.
However, it's quite difficult to recognise the background color as the highlighting of the current selected path in the hoovered tree.
A "real" tree structure including buttons to open and close the sub tree would easier to understand in my opinion.

@olibu
Copy link
Contributor Author

olibu commented Apr 10, 2024

I have concept draft for a new interactive tree view based on the latest esm branch in my repository.
https://github.com/olibu/asn1js/tree/treeview

@lapo-luchini
What do you think about it.

@lapo-luchini lapo-luchini mentioned this pull request Apr 19, 2024
@lapo-luchini
Copy link
Owner

I don't think that this is required any more

Okay! Then (if I didn't misunderstand your comment, else feel free to re-open it) I'll close this PR and we can talk about feature/treeview in #87. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants