Remove unused imports #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the file data_reader/transport.py, the open_socket method of the TransportProtocol class uses the timeout and port variables, I believe these are the self.timeout and self.port instance atributes
|
|
In the file seed_db.py is imported the class TransductorModel from transductor_model.models. I checked and this model dont exists.
This script was raising an ImportError, so i commented the line that ran this script from the start.sh file for the container to be created without errors
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed all unused imports pointed by flake8.
Fix undefined variables on data_reader/transport.py
Removing seed_db.py script from start.sh file (this script is importing a model that does not exist)